Fix leftmost title pixel sometimes being cut off #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When centering the title text in an window of even width, the leftmost pixel of the title text is being cut off. This is because the clip rect is positioned according to x as a floating point, but the pixmap is positioned according to x as cast to an integer. Casting a float to an int floors it.
For example when x is
100.5, the mask will start at x100.5, but the pixmap will be drawn at x100, so a bit of the title text will be cut off.This is noticeable in the following recording, which shows the window being slowly resized. Focus on the bottom-left of the first "/".
Screencast.from.2023-11-10.20-44-40.webm